Skip to content

feature/delete-team#112

Merged
mdawoud27 merged 2 commits into
mainfrom
feature/106/delete_team
Apr 7, 2025
Merged

feature/delete-team#112
mdawoud27 merged 2 commits into
mainfrom
feature/106/delete_team

Conversation

@mdawoud27
Copy link
Copy Markdown
Contributor

PR Checklist (required)

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

Related Issue

Closes #106

@mdawoud27 mdawoud27 added the documentation Improvements or additions to documentation label Apr 7, 2025
@mdawoud27 mdawoud27 requested a review from Copilot April 7, 2025 16:49
@mdawoud27 mdawoud27 self-assigned this Apr 7, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/docs/swagger.json: Language not supported
Comments suppressed due to low confidence (2)

src/routes/team.routes.js:47

  • Ensure that the removal of the trailing slash is intentional and that clients consuming this endpoint are updated accordingly.
'/api/organization/:organizationId/department/:departmentId/team/:teamId'

src/controllers/team.controller.js:760

  • Verify that the authorization logic in deleteTeam has been updated to enforce the extended access roles reflected in this documentation.
* @access private - admins, organization owners, department managers, or team creators

@mdawoud27 mdawoud27 merged commit f176023 into main Apr 7, 2025
11 checks passed
@mdawoud27 mdawoud27 deleted the feature/106/delete_team branch April 7, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Delete a team

2 participants